Homework_RecyclerView#55
Open
AnGuru-60 wants to merge 1 commit intoAndroid-Developer-Basic:masterfrom
Open
Conversation
| val list = currentList.toMutableList() | ||
| list.removeAt(position) | ||
| submitList(list) | ||
| notifyDataSetChanged() |
There was a problem hiding this comment.
ListAdapter автоматически обновляет список через DiffUtil при вызове submitList, поэтому notifyDataSetChanged здесь не нужен и может вызвать лишние перерисовки. Можно убрать из методов removeItem и addItems.
| } | ||
|
|
||
| fun removeItem(position: Int){ | ||
| val list = currentList.toMutableList() |
There was a problem hiding this comment.
Можно добавьте проверку валидности позиции перед удалением
| val totalItemCount = layoutManager.itemCount | ||
| val lastVisibleItem = layoutManager.findLastVisibleItemPosition() | ||
|
|
||
| if (lastVisibleItem + 1 == totalItemCount) { |
There was a problem hiding this comment.
При быстром скролле пагинация может срабатывать несколько раз подряд, что приводит к множественным одновременным загрузкам данных. Можно использовать флаг isLoading, чтобы предотвратить повторные вызовы addItems до завершения текущей загрузки
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.